components

6.4 KB

1. # Report 002: components.hybriel code order, no behaviour change
3. **Where:** commits on main in loreana:/media/STORAGE/projects/components.hybriel.worldapi.org (parent 0994575):
4. - `d29f35b`: file moves (1/4)
5. - `172914a`: topic, map and thin wrappers (2/4)
6. - `e747cfa`: `let` (3/4)
7. - the docs + tests commit (4/4), which also holds this report and the mission brief
9. Not pushed, not deployed. No `.env` read (the copies used for the runs exclude `.env*`). Only ports 8750–8759 were used. Every server and Chrome was stopped by its PID; 8750–8759 are free.
11. ## Counts (before → after; `python3 tests/letcount.py .`)
13. | | before (0994575) | after |
14. |---|---|---|
15. | `.hl` files in the root | 2 (project.hl, styles.hl) | **1** (project.hl) |
16. | project.hl lines | 81 | 89 (+ the 8-line map comment; it had no functions before either) |
17. | `let` total | 471 | 213 |
18. | `let` never reassigned | **255** | **0** |
20. The 213 `let`s left are all needed:
21. - 128 are reassigned;
22. - 69 are in a loop body (Hybriel refuses a plain declaration there on the 2nd pass);
23. - 3 have the name of a member or import of the file (`now` in date-picker and range-picker, `lines` in md-editor);
24. - 13 are declared twice in one function (md-editor: `j`, `inner`, `p`, `t`, `sel`, `b`…; code-editor: `at`, `j`).
26. `tests/letcount.py` (from ident) now scans `components/` recursively, because there is one folder per component. Its "twice" check now also finds methods such as `name(args) {`. Before, it only found lambdas and `on`/`static` handlers. With the old check, 6 real twice-cases (md-editor `p`, `j`, `inner`) would have been dropped.
28. ## Layout
30. - **`components/styles.hl`**: was the root `styles.hl` (the site's own CSS). Its token import is now `../shared/tokens.hl`.
31. - **`lib/uploads.hl`** (new topic file): where the showcase keeps uploaded files.
32. - `storeUpload` (file upload demo) and `storeMdFiles` (Markdown editor demo);
33. - `extensionOf` (the known-kinds rule, with `kinds`);
34. - `dropOld` (the one-day expiry). Before, this loop existed twice, once in each demo.
35. - **Demos made thin:**
36. - `file-upload/demo.hl`: `on server saveFile(file) { return storeUpload(file) }`;
37. - `md-editor/demo.hl`: `on server mdUpload(files) { return storeMdFiles(files) }`.
38. - **`project.hl`**: the head comment is now the map (which file handles what). It held no functions before and holds none now. The `env` ternaries are config and stay.
39. - **Public files unchanged:**
40. - every `components/<name>/<name>.hl`, `clock.hl` and every README keep their names and paths;
41. - their only change is the dropped `let`s. A check of `git diff -U0` for step 3: 256 changed lines, each differs only by `let ` removed;
42. - so no element, class or selector that layouts' `theme/theme.hl` targets (`html code-editor`, `date-picker`, `file-upload`, `md-editor`, `modal-dialog`, `month-view`, `pagination`, `range-picker`) changed.
43. - **One README line:** md-editor/README.md now names `lib/uploads.hl` as where the demo keeps its files.
45. ## Tests
47. | test | result |
48. |---|---|
49. | gate `tests/browser.mjs` (8750, Chrome 8751–8759) | **220 passed, 0 failed** before and after each step |
50. | layouts.worldapi.org gate (code-only copy, run after mine, not in parallel) | **73/0** before; **73/0** with the changed component files copied in; `check-theme` 0 problems both times |
51. | same output (new `tests/same-output.mjs`) | identical (see below) |
53. **Same-output run** (`tests/same-output.mjs` + `tests/same-output-compare.py` + `tests/same-output-modules.py`; the commands are in README "Run, test, deploy" → "Same output"):
54. - **What it runs:** each tree runs from a code-only copy (no `.env`, its own `storage/`), with the server on 8750 and Chrome on 8751–8759.
55. - **What it records:**
56. - every HTTP answer: the 9 pages, the 8 READMEs, the icons, `/favicon.ico`, `app.css`, the manifest, `sw.js`, every browser module and runtime file a page loads, and two 404s;
57. - the hydrated DOM of all 9 pages;
58. - a **file upload**: a 300 KB drop and a chosen file on `/file-upload` (the component's DOM afterwards);
59. - a **md-editor drop**: a png plus a `run.exe` (stored as `.bin`), the demo's DOM, and the stored png served back with its headers;
60. - the sha256 of every stored file;
61. - the console problems.
62. - **Masks:** `?v=` hashes, source positions, times and upload names. Two runs of the OLD tree compare clean (66/66).
64. | step | result |
65. |---|---|
66. | step 1 | 66/66 the same |
67. | step 2 | pages, DOMs, uploads and stored files the same. 3 answers differ: the two demo modules (only their imported-statics tables, source positions, and md-editor demo's `kinds` member, which moved to lib and was never used in the browser) and the md-editor README (the intended edit) |
68. | step 3 | pages, DOMs, uploads and stored files the same. The 11 browser modules differ **only** in the declaration keyword: `var`/`let` → `const`, 256 in total, checked by replacing the keyword and comparing |
70. ## Found (in STATUS)
72. 1. **The function finder must see methods.**
73. - **What:** a name declared twice in one METHOD must keep `let`.
74. - **Why it was missed:** letcount's / unlet's old function finder only knew lambdas and `on`/`static` handlers.
75. - **Fixed in:** tests/letcount.py and `.scratch/m002/unlet.py`. `.scratch/m002/twice.py` (from ident) lists the cases.
76. 2. **layouts' copies were not verbatim.**
77. - layouts.worldapi.org's copies (80ce6ba, "verbatim copies of 0994575") differed from 0994575 in 13 `let out` → `out` lines.
78. - They now differ more: about 256 `let`s.
79. 3. **Moving a static changes only the module's tables**, not the page (as in gitoria).
81. ## Open
83. - **Not deployed** (that is the architect's job). Use the normal `./deploy.sh`. There is no data change.
84. - deploy.sh's rsync does not delete, so the old root `styles.hl` stays on Byrodin. It is unused; delete it by hand after the deploy.
85. - **layouts.worldapi.org** should re-copy the 8 component files (and the md-editor README) from this commit. Then its copies are verbatim again.
86. - The gate run above shows that this copy gives 73/0.
87. - I did not touch the layouts repo.
88. - **Long files left as they are:** md-editor.hl (1007 lines) and code-editor.hl (384 lines). They are public component files, single-file by design ("ONE file, own Style").
89. - **Not touched:** `plugins/` (vendored Hybriel).
90. - **Scratch** (gitignored) in `.scratch/m002/`:
91. - `old/`, `new-*`: code-only trees;
92. - `layouts-before/`, `layouts-after/`;
93. - `out-*`: same-output runs (no live data; only test uploads);
94. - `step.sh`, `unlet.py`, `twice.py`, `modcmp.py`;
95. - `gate-*.txt`, `layouts-gate-*.txt`, `compare-*.txt`.